On Mon, 17 Dec 2007 21:29:31 -0800, Junio C Hamano <gitster@xxxxxxxxx> wrote: > "H.Merijn Brand" <h.m.brand@xxxxxxxxx> writes: > > > On Mon, 17 Dec 2007 13:00:22 -0800, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > > >> "H.Merijn Brand" <h.m.brand@xxxxxxxxx> writes: > >> > >> > HP-UX does not have select.h, but it offers all select () functionality. > >> > The defines are in <sys/types.h> and <X11/fd.h> > >> > >> Will apply the patch as-is for now, only because I do not want major > >> surgery during rc period, but I think is can be improved. > > ... > >> Besides, isn't _HPUX_SOURCE a feature-test macro? Feature test macros > > > > That is defined in GNU gcc. I did not pass it with -D... > > Actually I changed my mind. I won't be applying this as is. > > For the selective inclusion of <sys/select.h>, I would prefer it see it > done like the attached. So do I > The main point is to limit the "platform" dependency to configure and > Makefile, and keep #ifdef in the actual header files expressed in more > generic terms (e.g. "do we need to (and can we) include sys/select.h > here?"). > > I am fuzzy about the uname_S part, so I won't be applying the attached > patch either; the attached is for demonstration purposes only. > > diff --git a/Makefile b/Makefile > index 617e5f5..f9f724a 100644 > --- a/Makefile > +++ b/Makefile > @@ -100,6 +100,9 @@ all:: > # > # Define NO_DEFLATE_BOUND if your zlib does not have deflateBound. > # > +# Define NO_SYS_SELECT_H if your C library header files do not have <sys/select.h> > +# but you do have select(2) (pre POSIX.1-2001 systems, e.g. HP-UX before 11.23). > +# > # Define NO_R_TO_GCC_LINKER if your gcc does not like "-R/path/lib" > # that tells runtime paths to dynamic libraries; > # "-Wl,-rpath=/path/lib" is used instead. > @@ -504,6 +507,9 @@ endif > ifneq (,$(findstring arm,$(uname_M))) > ARM_SHA1 = YesPlease > endif > +ifeq ($(uname_S),HP-UX) > + NO_SYS_SELECT_H = YesPlease > +endif # uname -s HP-UX # uname -r B.11.00 # -- H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/) using & porting perl 5.6.2, 5.8.x, 5.10.x on HP-UX 10.20, 11.00, 11.11, & 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin. http://qa.perl.org http://mirrors.develooper.com/hpux/ http://www.test-smoke.org http://www.goldmark.org/jeff/stupid-disclaimers/ - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
