Pierre Habouzit <madcoder@xxxxxxxxxx> writes: > On Mon, Dec 17, 2007 at 06:56:52PM +0000, Pierre Habouzit wrote: >> And I managed to resend the broken version, hurray myself. >> >> > + OPT_INTEGER('l', NULL, &list, "list tag names"), >> OPT_BOOLEAN >> >> >> >> Both these last minute fixes are applied to my public git.git. >> >> Let's now write 1000 times: I will run the test-suite before I send >> patches, I will rune the test-suite before I send patches, … > > oh and t7004 doesn't pass anymore because of the: > > git -n xxx -l or git -n "" -l tests. If we really want to allow that > (but it _REALLY_ feels wrong to me) we have to make '-l' a callback that > groks non integers as 0. Else the test also has to be fixed, I'm not > sure what to do here. I did not understand what "git tag -n xxx" was meant to do, either. Time to run blame and ask the responsible party? I suspect "-n ''" there might be meant as a way to spell the "no argument here -- use our default" instruction. It looks slightly nicer than that '{}' but not quite. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html