On Fri, 2007-12-14 at 13:57 -0800, Junio C Hamano wrote: > Kristian Høgsberg <krh@xxxxxxxxxx> writes: > > > When we commit or roll back the lock file the fd is automatically closed, > > so don't do that again. > > With your change, we do not check the return status from close(2) > anymore, which means that we may have run out of diskspace without > noticing and renamed the incomplete file into the real place. Oops? You're right of course. Ok, so lets just stick with the current config file handling for 1.5.4, it's not seriously broken. Kristian - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
