On Dec 15, 2007 7:35 PM, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > Hi, > > On Sat, 15 Dec 2007, Kelvie Wong wrote: > > > It shows a diffstat, and asks the user if they would like to continue, > > or show a full diff of the things getting reset. > > > > I know that many times, I do a reset --hard thinking I had commited a > > file already, but it turns out that I hadn't; and so this makes sure I > > don't lose any work when the caffeine wears off. > > > > Maybe it should also be made that only hard resets take this option, as > > I cannot see this being useful in other places. > > I am slightly negative on this patch. Not only do I think that it is both > easier and more natural to run diff/status/an-alias to see what a reset > would do, but the patch only handles the index_file part (missing the -- > <file> part AFAICT). > > Besides, the code style is incompatible with the surrounding code. > > Ciao, > Dscho > > [forgot to hit Reply To All again, sorry!] Ah, you're completely right about the index_file part (this is actually the first time I've looked at the git-code :P) Hrm.. I should have just used a shell script wrapper instead it seems. I do think something like this would be nice though. w.r.t. the style, you were referring to just the array initializers right? Or was there something else I did that doesn't look right? -- Kelvie Wong - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
