On Fri, Dec 14, 2007 at 10:12:32PM -0800, Junio C Hamano wrote: > > Is it just me who feels that the added code is much worse than the > disease? I wouldn't be surprised. Shell scripting is by no means my long suit - in fact, I am not even sure it's "a suit" of mine at all. I didn't like what I saw and basically had two options: 1. Send a "this is not user friendly" rant and get beaten up by "why don't you even try?" 2. Try and hack together something, submit it, and keep fixing it until it makes it - and learn something in the process, maybe at the price of being mocked at, but I don't care. In particular, as far as I _could_ see, there are probably at least one place I'm doing something potentially absurd, but couldn't figure out anything better: I'm not sure how to test if there is a stash name specified, so I tried: test "$flags" = "$@" but then it breaks when $@ has a space in it. Hence the pointless assignment to $arguments first. The reason I removed the --default option to rev-parse is that it doesn't distinguish between no stash name or an invalid one. I'm sure there are other things people don't like - some because my shell scripting sucks, some others maybe because of style differences. At any rate, I'm open to criticism. So bring it on. 8-) -- Jing Xue - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
