Peter Baumann <waste.manager@xxxxxx> writes: > So you are loosing some values in your trim_common_tail function by > making ctx only an int. (Not sure that it matters, but I noticed it > while glancing over your code). While it is true that this does not matter in practice (because the context value initially comes from the end user via -U parameter that is stored in a field of type int in diff_options structure), I agre that it is the right thing to do to use the same type as underlying xdiff library uses at the interface level. From the layering point of view. xdiff-interface.[ch] are meant to be a thin usability wrapper, it should not needlessly deviate from how the underlying xdiff operates. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
