Wincent Colaiuta <win@xxxxxxxxxxx> writes: > +test_expect_success 'check spaces as indentation (indent-with-non-tab: off)' ' > + > + git config core.whitespace "-indent-with-non-tab" > + echo " foo ();" > x && > + git diff --check > + > +' > + > +test_expect_failure 'check spaces as indentation (indent-with-non-tab: on)' ' > + > + git config core.whitespace "indent-with-non-tab" && > + echo " foo ();" > x && > + git diff --check > + > +' > + > test_done It is good to check both positive and negative cases, but I would prefer avoiding test_expect_failure. You cannot tell if the "git config" before the real test failed or "git diff --check" correctly reported whitespace breakage --- both would cause the test to pass. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
