Jeff King <peff@xxxxxxxx> writes: > We are duplicating the "!shown && ..." conditional branch from > log_tree_commit, which calls show_log. Why are we not calling show_log > instead of pretty_print_commit (I understand that show_log should end up > calling pretty_print_commit, but it is not immediately obvious that all > of the extra code in show_log is going to be ignored). Exactly. I think show_log() has become too complex, and when we want a oneline userformat, pretty-print-commit is more appropriate to use. Actually, when I re-review the code, I think the part should use format_commit_message() which is more to the point without any of the other "more generic" parameter pretty-print-commit takes. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
