On Mon, Dec 10, 2007 at 08:38:31PM -0800, Junio C Hamano wrote: > +get_tag_header implied-sign $commit commit $time >expect > +echo 'Another signed tag' >>expect > +echo '-----BEGIN PGP SIGNATURE-----' >>expect > +test_expect_success '-u implies signed tag' ' > + git-tag -u CDDE430D -m "Another signed tag" implied-sign && > + get_tag_msg implied-sign >actual && > + git diff expect actual > +' One thing that my original did test but this version doesn't: not only does -u imply -s, but -u implies -s which implies -a. IOW, using "-u" will put you in an editor (and a poorly done fix might have gotten this wrong, but apparently Linus is a super-genius). Your other two tests look good. -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
