Mike Hommey <mh@xxxxxxxxxxxx> writes: > Both codes are also buggy in case the ref is a symbolic ref, and that > happens. I got bitten by this while testing. > > Considering the assumption being made that refs are all properly filled > with sha1s, both codes are mostly equally bad. > > Fixing the issue would obviously be the subject for another patch. Ok, I'll reject [2/4] and expect a reroll. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html