Re: [PATCH 4/4] Add tests for pre-commit and commit-msg hooks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



El 8/12/2007, a las 13:29, Wincent Colaiuta escribió:

As desired, these pass for git-commit.sh, fail for builtin-commit (prior
to the fixes), and succeeded for builtin-commit (after the fixes).

Actually, that's a slight lie.

The commit-msg tests 9 and 10 (editing the commit message from the hook) fail for git-commit.sh (tested 1.5.3.4 and 1.5.3.7).

By the looks of it, this discrepancy isn't actually a bug in git- commit.sh, but is because of stuff that was in commit.c back in 1.5.3.7 and prior which causes a commit message like "foo" to yield "foo<unknown>" when you do a "git log --pretty=format:%s%b -1"; post 1.5.3.7 (on master) it instead yields "foo", which is what I was testing for.

Cheers,
Wincent


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux