Le vendredi 7 décembre 2007, Junio C Hamano a écrit :
> Junio C Hamano <gitster@xxxxxxxxx> writes:
> > Christian Couder <chriscool@xxxxxxxxxxxxx> writes:
> > ...
> >
> >>> > +init_browser_path() {
> >>> > + browser_path=`git config browser.$1.path`
> >>> > + test -z "$browser_path" && browser_path=$1
> >>> > +}
> >>>
> >>> Please do not contaminate the config file with something the user can
> >>> easily use a lot more standardized way (iow $PATH) to configure to
> >>> his taste.
> >>>
> >>> I'd suggest dropping this bit.
>
> Well, I changed my mind. It is a bit funny to have both firefox and
> iceweasel as "valid-tool", but if we consider $browser to define the
> external interface and $browser_path to define the implementation, it
> sort of makes sense to have that configuration. browser_path could be
> iceweasel for browser firefox.
>
> I'll squash the patch to update the one from the last round (as the last
> two patches are not yet accepted in 'next' yet), remove the html
> documentation path fallback, but will leave this part in.
Thanks.
> browser.*.path and web.browser configuration need to be documented, if
> not already, though.
Did you see this patch:
http://article.gmane.org/gmane.comp.version-control.git/67101
Christian.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
