On Wed, 5 Dec 2007, Junio C Hamano wrote: > Daniel Barkalow <barkalow@xxxxxxxxxxxx> writes: > > > On Tue, 4 Dec 2007, Junio C Hamano wrote: > > > >> The code calls fetch_pack() to get the list of refs it fetched, and > >> discards refs and always returns 0 to signal success. > >> > >> But builtin-fetch-pack.c::fetch_pack() has error cases. The function > >> returns NULL if error is detected (shallow-support side seems to choose > >> to die but I suspect that is easily fixable to error out as well). > >> > >> Shouldn't fetch_refs_via_pack() propagate that error to the caller? > > > > I think that's right. I think I got as far as having the error status from > > fetch_pack() actually returned correctly, and then failed to look at it. > > I'd personally avoid testing a pointer to freed memory, but that's > > obviously not actually wrong. > > > > -Daniel > > Hmph, is that an Ack that the patchlet is actually a bugfix? Yes. Acked-By: Daniel Barkalow <barkalow@xxxxxxxxxxxx> -Daniel *This .sig left intentionally blank* - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
