On Wed, 5 December 2007, Wincent Colaiuta wrote: > El 5/12/2007, a las 16:45, Jakub Narebski escribió: > > > Update configure.ac (and config.mak.in) to keep up with git > > development by adding [compile] test whether your library has > > an old iconv(), where the second (input buffer pointer) parameter > > is declared with type (const char **) (OLD_ICONV). > > > > Signed-off-by: Jakub Narebski <jnareb@xxxxxxxxx> > > --- > > This patch needs checking if it correctly sets OLD_ICONV > > when needed. I have checked only that it is not set when > > with new iconv() declaration. Could people using Cygwin > > (and other with OLD_ICONV: Darwin) test it? > > Before applying your patch: > > CC utf8.o > utf8.c: In function ‘reencode_string’: > utf8.c:328: warning: passing argument 2 of ‘iconv’ from incompatible > pointer type > CC convert.o > > After applying your patch: > > CC utf8.o > CC convert.o Do I understand correctly that above is excerpt from the output of the following sequence of commands before and after this patch applied? $ make configure $ ./configure [options] $ make Do you have something like below in ./configure output? configure: CHECKS for header files checking for old iconv()... yes > This on Darwin Kernel Version 9.1.0 (Mac OS X 10.5.1). Strange... in Makefile there is ifeq ($(uname_S),Darwin) NEEDS_SSL_WITH_CRYPTO = YesPlease NEEDS_LIBICONV = YesPlease OLD_ICONV = UnfortunatelyYes NO_STRLCPY = YesPlease NO_MEMMEM = YesPlease endif so the uname based guessing should set OLD_ICONV on Darwin... -- Jakub Narebski Poland - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
