Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes: > On Sun, 2 Dec 2007, Johannes Schindelin wrote: >> >> Darn. But when can "GIT_AUTHOR_DATE" be set to the empty string? I mean, >> I understand unset'ing it. But setting it to ""? > > Well, regardless, I think we should make sure that git-commit-tree never > writes out an invalid commit - no matter *how* insane input it gets. > Making it complain loudly (with a 'die("Oh, no, you don't!")') would be a > good idea. FWIW, fmt_ident() records the current time (before the kh/commit series, and after the fix I sent on top of kh/commit series), which may be a reasonable alternative. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html