Re: [PATCH] Adding menu for Emacs git.el

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"=?utf-8?q?R=C3=A9mi=20Vanicat?=" <vanicat@xxxxxxxxxx>, Remi Vanicat
<vanicat@xxxxxxxxxx> writes:

> Adding three menu to the git-status-mode of git.el : One for marking
> and unmarking, one for every thing you need when you have a conflict,
> and a last one for all the rest.
>
> Signed-off-by: Rémi Vanicat <vanicat@xxxxxxxxxx>

It looks good to me. A couple of minor details:

> +      ["Interctive Diff File" git-diff-file-idiff t]

There's a typo here.

> +      ["Show Uptodate" git-toggle-show-uptodate :style toggle :selected git-show-uptodate]
> +      ["Toggle Show Ignored" git-toggle-show-ignored :style toggle :selected git-show-ignored]
> +      ["Toggle Show Unknown" git-toggle-show-unknown :style toggle :selected git-show-unknown]))

I'd get rid of 'Toggle' on the last two for consistency.

BTW do you have a copyright assignment for Emacs?

-- 
Alexandre Julliard
julliard@xxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux