Hi, On Sat, 1 Dec 2007, Junio C Hamano wrote: > This avoids double exec() when execv_git_cmd() is used to spawn an > external git command. > > For this, execv_git_cmd() needs to be able to tell what's built-in. > This is done by introducing a new function git_builtin_command() that > checks the list of built-in commands and returns a pointer to the > cmd_struct if found. The same function is used from the git potty. IMNSHO this does not buy us anything, compared to my patch series. Your patch is larger, distributes the responsibility for the builtins to two files instead of one, and since we control what is builtin and what not, is not really less fragile with respect to what needs to be initialised. Besides, we lose a great opportunity to go in the direction of libification. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
