On Thu, Nov 29, 2007 at 05:10:45PM -0800, Junio C Hamano wrote: > > OK. What next? Did the patch I sent make sense? Do you want a cleaned up > > version with a commit message and signoff, or does it need work? > > It just hit me that breaking (as in diffcore-break) a filepair that is a > typechange may yield the same result, and if it works, that would be > conceptually cleaner. After all, a typechange is the ultimate form of > total rewriting (the similarity between the preimage and the postimage > is very low -- even their types are different, let alone contents). > > Compared to that, the rename_used++ in that codepath you touched feels > more magic to me. I have always been a bit confused about diffcore-break, so I am probably misunderstanding what you mean. But are you saying that diffcore-break.c:should_break should return 1 for typechanges? If so, that does not have the desired effect. -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
