Like when it is already specified through -C, -F or -m to git-commit. Signed-off-by: Alex Riesen <raa.lkml@xxxxxxxxx> --- Alex Riesen, Wed, Nov 28, 2007 22:10:59 +0100: > Johannes Schindelin, Wed, Nov 28, 2007 13:18:10 +0100: > > Besides, would this not be more elegant as > > > > setup_revisions(0, NULL, &rev, "HEAD"); > > Hmm... And I was so puzzled as to what that "def" argument could > possibly mean... Still am, in fact. But it works. > > > > + (void)run_diff_index(&rev, 1 /* cached */); > > > > (void)? > > I'll remove them and resubmit. Stupid custom. > Here it goes. builtin-commit.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/builtin-commit.c b/builtin-commit.c index a35881e..1a9a256 100644 --- a/builtin-commit.c +++ b/builtin-commit.c @@ -367,6 +367,28 @@ static int prepare_log_message(const char *index_file, const char *prefix) strbuf_release(&sb); + if (no_edit) { + struct rev_info rev; + unsigned char sha1[40]; + + fclose(fp); + + if (!active_nr && read_cache() < 0) + die("Cannot read index"); + + if (get_sha1("HEAD", sha1) != 0) + return !!active_nr; + + init_revisions(&rev, ""); + rev.abbrev = 0; + setup_revisions(0, NULL, &rev, "HEAD"); + DIFF_OPT_SET(&rev.diffopt, QUIET); + DIFF_OPT_SET(&rev.diffopt, EXIT_WITH_STATUS); + run_diff_index(&rev, 1 /* cached */); + + return !!DIFF_OPT_TST(&rev.diffopt, HAS_CHANGES); + } + if (in_merge && !no_edit) fprintf(fp, "#\n" -- 1.5.3.6.1014.g3543 - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html