Re: [PATCH] Replace misleading message during interactive rebasing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin schrieb:
You could still provide the "me" and unique_abbrev parameters, so that the first %s in _GIT_CHERRY_PICK_HELP would be replaced by the operation, and the second by the sha1. Hmm?

Gaah! First rule to safe programming: Don't use user input as format strings. getenv(_GIT_CHERRY_PICK_HELP) *is* user input. In this case, the caller knows exactly what the put into the help string, so it should do so.

-- Hannes

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux