Re: [StGit PATCH 07/10] Teach the new infrastructure about the index and worktree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2007-11-26 09:56:42 +0100, David Kågedal wrote:

> Karl Hasselström <kha@xxxxxxxxxxx> writes:
>
> > --- a/stgit/lib/git.py
> > +++ b/stgit/lib/git.py
> > @@ -95,6 +95,8 @@ class Commitdata(Repr):
> >          return type(self)(committer = committer, defaults = self)
> >      def set_message(self, message):
> >          return type(self)(message = message, defaults = self)
> > +    def is_empty(self):
> > +        return self.tree == self.parent.data.tree
> >      def __str__(self):
> >          if self.tree == None:
> >              tree = None
>
> But a Commitdata describes a Git commit, right? And not an StGit
> patch.

Yes.

> So what does it mean to say that a commit is empty? I could just as
> well mean that the tree is the null tree. I think I would have
> called this "is_nochange" or something.

Good point.

-- 
Karl Hasselström, kha@xxxxxxxxxxx
      www.treskal.com/kalle
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux