Using the helper function to test for absolute paths makes porting easier. Signed-off-by: Steffen Prohaska <prohaska@xxxxxx> --- diff-lib.c | 2 +- lockfile.c | 2 +- setup.c | 2 +- trace.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) BTW, what happend to the msysgit related patches: [PATCH 1/3] sha1_file.c: Fix size_t related printf format warnings [PATCH 2/3] builtin-init-db: use get_git_dir() instead of getenv() I never received comments about them, nor do I find them on pu. Steffen diff --git a/diff-lib.c b/diff-lib.c index f8e936a..d85d8f3 100644 --- a/diff-lib.c +++ b/diff-lib.c @@ -231,7 +231,7 @@ static int handle_diff_files_args(struct rev_info *revs, static int is_outside_repo(const char *path, int nongit, const char *prefix) { int i; - if (nongit || !strcmp(path, "-") || path[0] == '/') + if (nongit || !strcmp(path, "-") || is_absolute_path(path)) return 1; if (prefixcmp(path, "../")) return 0; diff --git a/lockfile.c b/lockfile.c index 258fb3f..f45d3ed 100644 --- a/lockfile.c +++ b/lockfile.c @@ -94,7 +94,7 @@ static char *resolve_symlink(char *p, size_t s) return p; } - if (link[0] == '/') { + if (is_absolute_path(link)) { /* absolute path simply replaces p */ if (link_len < s) strcpy(p, link); diff --git a/setup.c b/setup.c index 43cd3f9..2c7b5cb 100644 --- a/setup.c +++ b/setup.c @@ -59,7 +59,7 @@ const char *prefix_path(const char *prefix, int len, const char *path) const char *prefix_filename(const char *pfx, int pfx_len, const char *arg) { static char path[PATH_MAX]; - if (!pfx || !*pfx || arg[0] == '/') + if (!pfx || !*pfx || is_absolute_path(arg)) return arg; memcpy(path, pfx, pfx_len); strcpy(path + pfx_len, arg); diff --git a/trace.c b/trace.c index 0d89dbe..d3d1b6d 100644 --- a/trace.c +++ b/trace.c @@ -37,7 +37,7 @@ static int get_trace_fd(int *need_close) return STDERR_FILENO; if (strlen(trace) == 1 && isdigit(*trace)) return atoi(trace); - if (*trace == '/') { + if (is_absolute_path(trace)) { int fd = open(trace, O_WRONLY | O_APPEND | O_CREAT, 0666); if (fd == -1) { fprintf(stderr, -- 1.5.3.6.878.g8c9e2 - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html