Re: [PATCH] builtin-add: fix command line building to call interactive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



El 25/11/2007, a las 19:36, Junio C Hamano escribió:

I _think_ the only remaining thing is --patch, and none of the pathspec
thing is needed.

You're probably right; the pathspec validation is probably not necessary (and you may recall that my original patch didn't include it; I only tried adding after you said it might be appropriate to have the "--error-unmatch" behaviour). This is probably more convenient for the user, as it allows them to pass "sloppy" parameters like the following:

	git-add -i *.h

(Note that's "*.h" and not "\*.h"). In the Git repository, without validation, this just works. With strict validation, it would complain:

	error: pathspec 'common-cmds.h' did not match any file(s) known to git.

So just forgetting about the validation is probably the right thing to do.

As for adding the --patch option, I'll stand back and see if someone more skilled than I wants to do it; should only be a few lines and will save traffic to the list because they'll probably get it right first time.

Cheers,
Wincent

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux