Re: [PATCH 2/3] Move pathspec validation into interactive_add

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Wincent Colaiuta <win@xxxxxxxxxxx> writes:


> Instead of throwing away the return status of pathspec_match() I am
> keeping it, and any successful match breaks out of the loop early.

Leaving it early before checking if all the given pathspecs are
used defeats the whole "error-unmatch" business, doesn't it?

> Another issue is that simple shell shortcuts don't work, so something
> as simple as "git-add -i ." will report:
>
>   error: pathspec '.' did not match any file(s) known to git.

The sample code snippet I sent you probably is not doing 
get_pathspec() before using the "pattern" thing.  And I suspect
that ...

> Likewise it's not possible to validate pathspecs like "\*.sh" either,

... may be related to that.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux