On Thu, Nov 22, 2007 at 03:29:03AM -0800, Junio C Hamano wrote: > There was one funny thing I fixed up. The arguments to the > interactive_add() function in builtin-add.c was like this: > > int interactive_add(const char **argv, int argc) > > Anybody who writes a function with such a signature and do not > notice its craziness before sending it out either (1) has never > programmed in C, (2) did not review the code before submitting, > or (3) worked too hard and was too tired. Heh. I looked the patch over, noticed a subtle memcpy issue, and didn't even notice the craziness. I claim 3, also. -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
