Re: [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano schrieb:
Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

Hi,

On Wed, 21 Nov 2007, Steffen Prohaska wrote:

We have a function set_git_dir(). So let's use it, instead of setting the evironment directly.
Does this not have a fundamental issue? When you call other git programs with run_command(), you _need_ GIT_DIR to be set, no?

It is much worse.  set_git_dir() does not just setenv() but does
setup_git_env() as well.

I don't see what's wrong with that. Could you please explain?

-- Hannes
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux