On 25/03/20 11:10AM, Phillip Wood wrote: > Hi Justin > > On 20/03/2025 01:46, Justin Tobler wrote: > > > > A side-effect of this change is that the location of the first > > `git_default_branch_name()` gets deferred to a later point of execution. > > This matters because `git_default_branch_name()` only computes the > > default branch name once and returns a cached value for subsequent > > invocations. After this change, the `git_default_branch_name()` call > > site that actually computes the value becomes `guess_remote_head()` and > > is configured to always show the advice message. > > Isn't the fundamental cause of this bug that advise() ignores GIT_ADVICE? > I'm not really clear why "git --no-advice" only applies to advice that is > guarded by advice_enabled() when it is documented as disabling all advice > hints.
