Re: [PATCH 01/13] pack-objects: extract should_attempt_deltas()

[Derrick Stolee <stolee@xxxxxxxxx>]

On 3/12/2025 5:01 PM, Taylor Blau wrote:
> On Mon, Mar 10, 2025 at 01:50:43AM +0000, Derrick Stolee via GitGitGadget wrote:

>> +static int should_attempt_deltas(struct object_entry *entry)
>> +{
>> +	if (DELTA(entry))
>> +		return 0;
>> +
...>> -		if (DELTA(entry))
>> -			/* This happens if we decided to reuse existing
>> -			 * delta from a pack.  "reuse_delta &&" is implied.
>> -			 */
> 
> It looks like this comment went away when this part of prepare_pack()
> was extracted into should_attempt_deltas().
> 
>> -			continue;

Good catch. 

Thanks,
-Stolee