On Wed, Mar 19, 2025 at 9:00 AM Patrick Steinhardt <ps@xxxxxx> wrote: > > On Tue, Mar 18, 2025 at 06:21:41PM -0400, Taylor Blau wrote: > > curl supports a few options to control when and how often it should > > instruct the OS to send TCP keepalives, like KEEPIDLE, KEEPINTVL, and > > KEEPCNT. Until this point, there hasn't been a way for users to change > > what values are used for these options, forcing them to rely on curl's > > defaults. > > > > But we do unconditionally enable TCP keepalives without giving users an > > ability to tweak any fine-grained parameters. Ordinarily this isn't a > > problem, particularly for users that have fast-enough connections, > > and/or are talking to a server that has generous or nonexistent > > thresholds for killing a connection it hasn't heard from in a while. > > > > But it can present a problem when one or both of those assumptions fail. > > For instance, I can reliably get an in-progress clone to be killed from > > the remote end when cloning from some forges while using trickle to > > limit my clone's bandwidth. > > Does this mean that our defaults are insufficient, as well? It's nice to > add a way to adapt those settings for the future, but ideally no user > should ever have to manually tweak them and Git should work out of the > box. Was going to comment with the same question.
