On 2025-03-18 at 18:02:51, Tuomas Ahola wrote: > The default formatting of commit notes by git format-patch --notes > doesn't make a very good fit. It would be more beneficial to use the > raw format for CMIT_FMT_EMAIL and CMIT_FMT_MBOXRD. I don't really use notes, so I don't have a strong opinion, but I think "doesn't make a very good fit" isn't really a compelling argument, since it's very opinionated and short on details. Maybe you could explain the current status in terms of the output one receives and mention in detail why it's unsuitable, and then explain the benefits of the raw format in terms of its output and why it's better. Ideally, I, someone who has touched the notes code but is not intimately familiar with it, would be able to understand the advantages and disadvantages of the change by reading the commit message, and I'm afraid I don't right now. My guess, based on the very small amount of code I've touched there and my recollection from that, is that there's some sort of prefix printed in the format-patch output, and that prevents the notes output from being nicely formatted as an additional explainer when sending a patch, so it requires further editing, which is a hassle. Therefore, it would be more convenient for users to not have to do that by using the raw mode. But that's just a guess. -- brian m. carlson (they/them or he/him) Toronto, Ontario, CA
Attachment:
signature.asc
Description: PGP signature
