On Sat, Mar 15, 2025 at 11:38 PM Elijah Newren <newren@xxxxxxxxx> wrote: > > On Fri, Mar 14, 2025 at 10:29 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > > > Elijah Newren <newren@xxxxxxxxx> writes: > > > > >> Licensing, mostly, as clever things we see are not necessarily home > > >> grown. I know the patch came with DCO sign-off, but it does not > > >> hurt to double check. > > > > > > These two lines: > > > > > >> +extern int not_supposed_to_survive; > > >> +#define assert(expr) ((void)(not_supposed_to_survive || (expr))) > > > > > > , which serve as the core trick, I had used elsewhere before. > > > > It may be arguable that it is too small to be copyrightable and > > there is no other way to express the idea behind that check, but > > in any case ... > > That's what I had been assuming, but then you, brian, and Taylor all > pointed out how clever it was making me think otherwise. > > > > Anyone got a clever alternative? > > > > ... as I cannot unsee your patch, I cannot be the one who comes up > > with a clever alternative, if we are worried about licensing with > > what you posted X-<. > > Turns out we don't need an alternative. I contacted the author, who > responded and placed the two-liner into the public domain with no > warranty of any kind. I'll send a re-roll with an updated commit > message. And of course, in my excitement to send a re-roll addressing that issue, I totally spaced fixing the style issues you pointed out. I'll wait a couple days for any comments and then send a re-roll with those fixes.
