Hey Ben, thanks for the response > > I'm in a poor position to judge, but I suspect reviewing this commit > would be easier if each bullet was a separate commit. See > Documentation/SubmittingPatches [[separate-commits]] (HTML: > https://git-scm.com/docs/SubmittingPatches#separate-commits). > Actually that's an amazing point. I was thinking the same and will start a new patch with individual bullet patches within a thread as soon as possible. > > Agreed as discussed in the other thread, thanks for doing this! > > > > > ... > > @@ -149,8 +143,14 @@ subcommand and contained within `builtin/`. So it makes sense to implement your > > command in `builtin/psuh.c`. Create that file, and within it, write the entry > > point for your command in a function matching the style and signature: > > > > +The following line represents the function signature for any builtin/<filename.c> file that we add: > > This line doesn't look necessary, or should at least replace the > sentence immediately prior (which shows up in the hunk context). > Ok I will once check and make sure the updated patch has this rectified. Thanks for the feedback > > +---- > > > -- > D. Ben Knoble Thanks, Jay
