Hi Junio, thanks a lot for taking time to review my patch.
That is exactly Patrick suggested (go back and read it). I agree with him that the updated stronger check is an improvement and it deserves to be explained in the commit message.
I apologize for miscomunication. I was agreeing with the suggestion. It was redundant on my part.
$ >this-is-file $ ln -s this-is-file this-is-symlink $ test -f this-is-symlink; echo $? 0 $ test -f this-is-file; echo $? 0 And if you are not unsure, then learn to be unsure more often ;-)
Ah, thank you. Sorry I din't know symlink were regular files. I'll be more careful with other things next time.
