On 25/03/12 08:50AM, Patrick Steinhardt wrote:
> On Mon, Mar 10, 2025 at 02:28:28PM -0500, Justin Tobler wrote:
> > diff --git a/builtin/rev-list.c b/builtin/rev-list.c
> > index 04d9c893b5..86b3ce5806 100644
> > --- a/builtin/rev-list.c
> > +++ b/builtin/rev-list.c
> > @@ -757,6 +778,14 @@ int cmd_rev_list(int argc,
> > usage(rev_list_usage);
> >
> > }
> > +
> > + if (nul_delim) {
> > + if (revs.graph || revs.verbose_header || show_disk_usage ||
> > + info.show_timestamp || info.header_prefix || bisect_list ||
> > + use_bitmap_index || revs.edge_hint || arg_missing_action)
> > + die(_("-z option used with unsupported option"));
> > + }
> > +
>
> Not sure whether it's worth it, but do we maybe want to add a comment
> here that mentions that this isn't an inherent limitation, but rather
> that the initial implementation simply didn't implement compatibility
> with these options? This would explicitly keep the door open for any
> future improvements in this area.
That's fair. I'll mention this is a comment that way we know support
NUL-delimited mode support can be added for some of the options in the
future.
Thanks
-Justin
