On Tue, Mar 11, 2025 at 5:59 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Christian Couder <christian.couder@xxxxxxxxx> writes: > > We could have modified strvec_push() to behave like > > strvec_push_nodup() and accept `NULL`, but it's not clear that it's > > the right thing to do for the strvec API. 'strvec' is a kind of NULL > > terminated array that is designed to be compatible with 'argv' > > variables used on the command line. So we might want to disallow > > pushing any `NULL` in it instead. > > > > It's also not clear if `xstrdup(NULL)` should crash or BUG or just > > return NULL. > > Yup, the above two paragraphs are irrelevant, I would think. I have removed them. Thanks.
