On Fri, Mar 7, 2025 at 6:19 AM Patrick Steinhardt <ps@xxxxxx> wrote: > > Hi, > > this patch series is another step to remove our dependency on the global > `the_repository` variable. The series focusses on subsystems related to > objects. > > The intent here is to work towards libification of the whole subsystem > so that we can start splitting out something like an object "backend". > It is thus part of a set of refactorings aimed at allowing pluggable > object databases eventually. I'm not discussing that bigger effort yet, > mostly because it's still taking shape. So these patch series contains > things that make sense standalone, even if pluggable ODBs never get to > be a thing. Sounds like a good goal; and the series is helpful regardless of whether we get there. > Note that this patch series stop short of dropping `the_repository` in > "object-file.c". This is a bigger undertaking, so I'm pushing that into > the next patch series. > > The series is built on top of cb0ae672aea (A bit more post -rc0, > 2025-02-27) with ps/path-sans-the-repository at 028f618658e (path: > adjust last remaining users of `the_repository`, 2025-02-07) merged into > it. > > Changes in v2: > - Point out why t1050 had to be adapted. > - Drop the rename of `get_max_object_index()` and > `get_indexed_object()`. > - Fix a couple of commit message typos. > - Link to v1: https://lore.kernel.org/r/20250303-b4-pks-objects-without-the-repository-v1-0-c5dd43f2476e@xxxxxx > > Changes in v3: > - Fix a semantic conflict with an in-flight patch series. > - Link to v2: https://lore.kernel.org/r/20250306-b4-pks-objects-without-the-repository-v2-0-f3465327be69@xxxxxx > > Thanks! > > Patrick > > --- > Patrick Steinhardt (12): > csum-file: stop depending on `the_repository` > object: stop depending on `the_repository` > pack-write: stop depending on `the_repository` and `the_hash_algo` > environment: move access to "core.bigFileThreshold" into repo settings > pack-check: stop depending on `the_repository` > pack-revindex: stop depending on `the_repository` > pack-bitmap-write: stop depending on `the_repository` > object-file-convert: stop depending on `the_repository` > delta-islands: stop depending on `the_repository` > object-file: split out logic regarding hash algorithms > hash: fix "-Wsign-compare" warnings > hash: stop depending on `the_repository` in `null_oid()` I read through the series. I had a couple small comments on patch 12. Overall, I really like how you've divided things up; it makes it easy for review, especially combined with --color-diff.
