Taylor Blau <me@xxxxxxxxxxxx> writes: > Fix this by only adding "HEAD" to the ref prefixes when we know that we > are already limiting the advertisement. In either case we'll learn about > HEAD (either through the limited advertisement, or implicitly through a > full advertisement). Good. "implicitly through a full advertisement" is a good thing to explicitly state here ;-) > Reported-by: Igor Todorovski <itodorov@xxxxxxxxxx> > Co-authored-by: Jeff King <peff@xxxxxxxx> > Signed-off-by: Jeff King <peff@xxxxxxxx> > Signed-off-by: Taylor Blau <me@xxxxxxxxxxxx> > --- > Peff and I talked about this today, and neither of us could find any > reasons not to pursue the approach listed in the footnote of > > <20250221072558.GA572877@xxxxxxxxxxxxxxxxxxxxxxx> > > , but this is a more conservative approach that should fix the issue and > apply cleanly on top of 'maint'. It may be worth picking this into 2.49, > even though we are already quite late into the -rc cycle, this is a > fairly nasty bug. Thanks, both.
