Jeff King <peff@xxxxxxxx> writes: > I was disappointed that the compiler didn't complain, though. Maybe we > should do this: Indeed. It would have helped us if it were already there in place. > -- >8 -- > Subject: [PATCH] config.mak.dev: enable -Wunreachable-code > > Having the compiler point out unreachable code can help avoid bugs, like > the one discussed in: > > https://lore.kernel.org/git/20250307195057.GA3675279@xxxxxxxxxxxxxxxxxxxxxxx/ > > In that case it was found by Coverity, but finding it earlier saves > everybody time and effort. > > We can use -Wunreachable-code to get some help from the compiler here. > Interestingly, this is a noop in gcc. It was a real warning up until gcc > 4.x, when it was removed for being too flaky, but they left the > command-line option to avoid breaking users. See: > > https://stackoverflow.com/questions/17249934/why-does-gcc-not-warn-for-unreachable-code Wow, now they leave their users confused, making them wondering why their command line option does not do anything useful ;-) > However, clang does implement this option, and it finds the case > mentioned above (and no other cases within the code base). And since we > run clang in several of our CI jobs, that's enough to get an early > warning of breakage. Yes, this is great. Thanks.
