On 05/03/2025 15:53, Junio C Hamano wrote:
We correctly omit builtin/pack-objects.o from BUILTIN_OBJS, but
forgot to add "git pack-redundant" on the EXCLUDED_PROGRAMS list,
which made "make check-docs" target notice that the command has been
removed but still is documented.
Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
---
* The command is still listed in the resulting "git help git"
output, as cmd-list.perl does not yet know which commands on the
list are to be ignored under WITH_BREAKING_CHANGES.
Good catch. It seems the meson build was also forgotten in 68f51871df8
(builtin/pack-redundant: remove subcommand with breaking changes,
2025-01-22) as we still compile builtin/pack-redundant.c and build the
documentation. We should probably wrap the function declaration for
cmd_pack_redundant() in builtin.h with "#ifndef WITH_BREAKING_CHANGES"
as well though I don't think that is urgent.
Best Wishes
Phillip
Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git c/Makefile w/Makefile
index a9b2de0692..95ac0820e9 100644
--- c/Makefile
+++ w/Makefile
@@ -1283,7 +1283,9 @@ BUILTIN_OBJS += builtin/mv.o
BUILTIN_OBJS += builtin/name-rev.o
BUILTIN_OBJS += builtin/notes.o
BUILTIN_OBJS += builtin/pack-objects.o
-ifndef WITH_BREAKING_CHANGES
+ifdef WITH_BREAKING_CHANGES
+EXCLUDED_PROGRAMS += git-pack-redundant
+else
BUILTIN_OBJS += builtin/pack-redundant.o
endif
BUILTIN_OBJS += builtin/pack-refs.o
