Mahendra Dani <danimahendra0904@xxxxxxxxx> writes: > On Tue, Mar 4, 2025 at 11:14 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: >> >> Mahendra Dani <danimahendra0904@xxxxxxxxx> writes: >> >> > Yes, due to the use of the "-f" flag, it's not necessary to explicitly >> > check the lack of file using `test -e`. >> > But if we drop the "-f" flag, we will have to check the lack of file >> > using `test -e` or >> > `test_path_is_file()`. >> >> Isn't it the other way around? >> >> $ rm -f nosuch ; echo $? >> 0 >> $ rm nosuch ; echo $? >> rm: cannot remove 'nosuch': No such file or directory >> 1 >> > > Yes, you are right. > With the "-f" flag, `rm` returns exit code 0 irrespective of whether > the file is present or not. > Thus, the `test -e` check is _required_ if we drop the "-f" flag to > return the correct exit code. > > I apologize for the mistake. No need for an apology when correcting technical mistakes, which we all make.
