Hi Patrick, On Tue, 4 Mar 2025, Johannes Schindelin wrote: > On Tue, 4 Mar 2025, Patrick Steinhardt wrote: > > > On Fri, Feb 28, 2025 at 04:45:31PM -0800, Junio C Hamano wrote: > > > * ps/reftable-sans-compat-util (2025-02-18) 18 commits > > > - Makefile: skip reftable library for Coccinelle > > > - reftable: decouple from Git codebase by pulling in "compat/posix.h" > > > - git-compat-util.h: split out POSIX-emulating bits > > > - compat/mingw: split out POSIX-related bits > > > - reftable/basics: introduce `REFTABLE_UNUSED` annotation > > > - reftable/basics: stop using `SWAP()` macro > > > - reftable/stack: stop using `sleep_millisec()` > > > - reftable/system: introduce `reftable_rand()` > > > - reftable/reader: stop using `ARRAY_SIZE()` macro > > > - reftable/basics: provide wrappers for big endian conversion > > > - reftable/basics: stop using `st_mult()` in array allocators > > > - reftable: stop using `BUG()` in trivial cases > > > - reftable/record: don't `BUG()` in `reftable_record_cmp()` > > > - reftable/record: stop using `BUG()` in `reftable_record_init()` > > > - reftable/record: stop using `COPY_ARRAY()` > > > - reftable/blocksource: stop using `xmmap()` > > > - reftable/stack: stop using `write_in_full()` > > > - reftable/stack: stop using `read_in_full()` > > > (this branch is used by ps/reftable-windows-unlink-fix.) > > > > > > Make the code in reftable library less reliant on the service > > > routines it used to borrow from Git proper, to make it easier to > > > use by external users of the library. > > > > > > Waiting for Acks, especially for Windows bits? > > > source: <20250218-pks-reftable-drop-git-compat-util-v6-0-8c1f39fb4c02@xxxxxx> > > > > Johannes, did the new version of this patch series make your life any > > easier? As far as I can see the conflicts in your "shears/seen" branch > > seem to have been fixed, and the failing pipeline seems to be due to > > other issues. If so, we would be able to move ahead with this patch > > series and the dependent fix for Windows below. > > Honestly, I cannot say whether it made my life any easier. As you can see > from > https://github.com/git-for-windows/git/actions/workflows/main.yml?query=branch%3Ashears%2Fseen, > the `shears/seen` branch failed to update automatically since I updated it > manually last Thursday. According to > https://github.com/git/git/activity?ref=seen, there have been 5 updates > that were hence missed. > > I'll try to update the `shears/seen` branch now, but I'll time-box it to > half an hour because I really planned on taking care of other issues. It seems that there are the usual CMake-related breakages (not related to ps/reftable-sans-compat-util, but to the introduction of the `CLAR_TEST_OBJS` or at least the `lib-oid` addition to that). I hope that the tip commit of `shears/seen` that I just pushed addresses that, but I ran out of time to monitor this. And there are some pretty bad `exit code 127` problems in the unit tests on Windows, see e.g. https://github.com/git-for-windows/git/actions/runs/13648196783/job/38151312208#step:5:213 (but again, I ran out of the allotted time). Ciao, Johannes
