Junio C Hamano wrote:
> Todd Zullinger <tmz@xxxxxxxxx> writes:
>
>> Indeed. I haven't looked closely at the CI bits to see how
>> we might be able to improve this. When we skip tests
>> unintentionally we just don't see that currently.
>
> In any case, while the t0450 was inadvertently disabled this way, a
> topic seems to have escaped to 'master' already with an inconsistent
> synopsis section and help text.
>
> Here is a fix.
I'm glad that's already paying off; it helps prove the patch
nicely.
I wondered for a moment why I didn't catch it with any of my
test runs. But it's simply that the rpm build tests were on
top of 2.49.0-rc0 and my local branch for this was built on
top of tz/doc-txt-to-adoc-fixes, neither of which contain
89be7d2774 (builtin/refs: add '--no-reflog' flag to drop
reflogs, 2025-02-21).
> --- >8 ---
> Subject: [PATCH] refs: show --no-reflog in the help text
>
> We forgot that we must keep the documentation and help text in sync.
>
> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
> ---
> builtin/refs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/refs.c b/builtin/refs.c
> index c459507d51..44d592a94c 100644
> --- a/builtin/refs.c
> +++ b/builtin/refs.c
> @@ -8,7 +8,7 @@
> #include "worktree.h"
>
> #define REFS_MIGRATE_USAGE \
> - N_("git refs migrate --ref-format=<format> [--dry-run]")
> + N_("git refs migrate --ref-format=<format> [--no-reflog] [--dry-run]")
>
> #define REFS_VERIFY_USAGE \
> N_("git refs verify [--strict] [--verbose]")
The fix looks obviously correct. :)
--
Todd
