Re: [PATCH v4 2/4] diff: add option to skip resolving diff statuses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/02/28 09:29AM, Patrick Steinhardt wrote:
> On Thu, Feb 27, 2025 at 06:26:02PM -0600, Justin Tobler wrote:
> > By default, `diffcore_std()` resolves the statuses for queued diff file
> > pairs by calling `diff_resolve_rename_copy()`. If status information is
> > already manually set, invoking `diffcore_std()` may change the status
> > value.
> > 
> > Introduce the `skip_resolving_statuses` diff option that prevents
> > `diffcore_std()` from resolving file pair statuses when enabled.
> 
> You mentioned to me that there was another user that basically abused
> `found_follow` to skip over this, which seems to be in "tree-diff.c".
> Would it make sense to convert that user to use the new mechanism, as
> well, so that we don't mix up options and state?

I was mixed up with something else and mistaken. There is only the one
expected existing user of the `found_follow` option. Apoligies for any
confusion.

-Justin




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux