On 25/02/26 02:58PM, phillip.wood123@xxxxxxxxx wrote: > I also think we might want to massage the output in the tests so that we're > not running test_cmp on files containing NUL bytes. Using > > git diff-tree -z ... | tr '\0' Q >actual > > would get rid of the NULs but does not improve the readability of the raw > diffs that much as everything is still on a single line. Using '\n' instead > of 'Q' would give us mulit-line output but we would lose confidence that the > original output was actually NUL terminated. Is the underlying motivation here to provide more feedback if a test fails? I somewhat have a preference for the test to be validating the output as it is actually expected. As you mentioned, getting rid of the NUL bytes wouldn't help with readability much and we probably wouldn't want to replace with `\n`, so maybe a simple "Binary files expect and actual differ" would be the most straightforward. If this is the preferred way to handle it, I can adapt in a followup version though. :) Thanks for the review! -Justin
