On 25/02/19 06:32PM, Justin Tobler wrote: > > >> The tree objects in the input are not expanded. With `git diff-pairs > > >> --raw` these objects are just printed again. With the `--patch` option, > > >> they are just ommitted. > > > > >Instead of getting expanded into its subpaths? > > The current implementation of diff-pairs is rather simple. It relies on > the upstream to feed it the file pairs with all the info upfront so it > can setup the diff queue. This means input with tree objects is also > queued as-is without being expanded further. I could maybe see a future > though where we want diff-pairs to be a more robust backend and supports > expanding these paths via -r option. Following previous discussion, > maybe it's fine to keep the initial implementation of diff-pairs on the > simple side for now. We could make diff-pairs die() for now if the -r > option is explicitly set. Thinking about this some more, adding support to expand trees in diff-pairs would alter patch output behavior. To better enable backwards compatible inclusion of this feature in the future, we may just want to die() for now if any tree object is present in diff-pairs input. -Justin
