Re: [PATCH 1/7] builtin/verify-tag: stop using `the_repository`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 15, 2025 at 04:27:17AM +0530, Usman Akinyemi wrote:
> @@ -35,7 +34,8 @@ int cmd_verify_tag(int argc,
>  		OPT_END()
>  	};
>  
> -	git_config(git_default_config, NULL);
> +	if (repo)
> +		repo_config(repo, git_default_config, NULL);
>  

I recently noticed that we have `usage_with_options_if_asked()`. Should
we use that function rather than making the call to `git_config()`
conditional? Otherwise it's not obvious why we have the conditional in
the first place.

The same comment also applies to subsequent commits.

Patrick




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux