Hi Hannes,
thank you for looping me in.
On Sun, 9 Feb 2025, Johannes Sixt wrote:
> Am 07.02.25 um 12:52 schrieb Patrick Steinhardt:
> > Split out the POSIX-related bits from "compat/mingw.h". This is in
> > preparation for splitting up "git-compat-utils.h" into a header that
> > provides POSIX-compatibility and a header that provides common wrappers
> > used by the Git project.
> >
> > Signed-off-by: Patrick Steinhardt <ps@xxxxxx>
> > ---
> > compat/{mingw.c => mingw/compat-util.c} | 28 ++--
> > compat/mingw/compat-util.h | 220 ++++++++++++++++++++++++++++++++
> > compat/{mingw.h => mingw/posix.h} | 216 +------------------------------
> > compat/msvc.c | 6 -
> > compat/msvc/compat-util.c | 6 +
> > compat/msvc/compat-util.h | 7 +
> > compat/{msvc.h => msvc/posix.h} | 8 +-
> > config.mak.uname | 6 +-
> > contrib/buildsystems/CMakeLists.txt | 2 +-
> > git-compat-util.h | 4 +-
> > meson.build | 8 +-
> > 11 files changed, 266 insertions(+), 245 deletions(-)
>
> I can agree with this rearrangement of compat/mingw.c. But the
> Git-for-Windows repository has much higher stakes with all the
> additional changes. I put Dscho on Cc.
This indeed causes massive friction. See for example
https://github.com/git-for-windows/git/actions/workflows/main.yml?query=branch%3Ashears%2Fseen,
which should ideally be updated with green builds as frequently as `seen`
is updated. It's dark red, and there are tons of gaps (which means that I
was not able to finish adapting to these changes).
Another problem introduced by this series is that now the same filename is
used in multiple directories, which makes it unnecessarily hard e.g. when
setting breakpoints in `gdb`, or when trying to follow `#include`s.
Granted, the problem already exists, e.g. with range-diff.c vs
builtin/range-diff.c, but I would hope that Git's source code would be
changed away from duplicate filenames instead of adding more.
Ciao,
Johannes
