On Sat, Feb 08, 2025 at 11:21:12PM -0800, Elijah Newren wrote: > On Sat, Feb 8, 2025 at 3:28 PM Josef Wolf <jw@xxxxxxxxxxxxx> wrote: > > > ahah, so it is passed via environment variable to the subprocess. > > > > I find this to be confusing: the primary call should not need this parameter, > > since it is invoked from HEAD anyway. > > No, the primary call I think would need the parameter too; it changes > HEAD immediately when it starts rebasing, and continues changing it > with each commit it rebases; since it's operating on older versions, > by default it'd likely pick the .gitattributes from those older > versions as it goes. OK. I see... > > Everything else gets it via env-vars. > > I'd assume this variable will also be passed to the commands which are invoked > > by the -x switch? > > Yes, I was surprised Phillip's command with --attr-source on the > outer-level git invocation worked until I discovered that the code > indeed sets the environment variable (which subprocesses, like those > created by the --exec/-x switch, will inherit). So, yes, the -x > switch stuff seems to inherit that environment variable that the > primary call sets in response to that parameter. Umm... OK... This means that specifying --attr-source to the commands for the -x switch is wrong, since they have a different HEAD? -- Josef Wolf jw@xxxxxxxxxxxxx
