On Thu, Feb 6, 2025 at 8:43 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Usman Akinyemi <usmanakinyemi202@xxxxxxxxx> writes: > > >> I obviously agree with the benefits enumerated in the above > >> paragraph. The simpler, the better. > >> > >> I however wonder ... > >> > >> > Add the `transfer.advertiseOSInfo` config option to address privacy > >> > concerns. It defaults to `true` and can be changed to `false`. > >> > >> ... if this configuration knob is at the right granularity. > > > > The conclusion now is that we should not add any config option since > > the GIT_USER_AGENT could actually allow the user to hide whatever > > info they do not want to share ? > > I wouldn't call that a conclusion (as you and I are the only people > who expressed their opinion on this so far), but that is my take on > it---tweaking only the (os) part in the agent string with a config > smells like the tweakability is at a wrong level. > Hi Junio, I was actually thinking about this inside the bathroom when it occurred to me that, according to the current implementation, GIT_USER_AGENT will not allow the user to specify an empty string at all. It is either you specify some value or we decide for you. I think we can add the config at a level that can disable the agent capability completely instead of only tweaking the (os) part. With this, the user can disable the agent capability completely, share whatever string they want using the GIT_USER_AGENT. What do you think ? Thanks.
