On Fri, Feb 07, 2025 at 11:03:15AM +0100, Toon Claes wrote: > Patrick Steinhardt <ps@xxxxxx> writes: > > > Stop using the `UNUSED` annotation and replace it with a new > > `REFTABLE_UNUSED` macro. The latter is a weaker guarantee compared to > > `UNUSED` as it only suppresses unused parameters without generating a > > warning in case a parameter marked as unused is in fact used. But it's > > good enough, and by relaxing the behaviour a bit we avoid having to wire > > up compiler-specific logic. > > I see MAYBE_UNUSED is defined as `__attribute__((__unused__))`, which as > far as I can tell is independent on the compiler, and has the same > effect as the implementation in this patch. Would it make sense to use > that defition instead? Or did you intentionally choose a statement that > will sit on a separate line so it's more obviously that line needs to be > deleted whenever the parameter is put in use? Interesting. I was checking the definition of `UNUSED`, which depends on the actual compiler we're using. But you're right, `MAYBE_UNUSED` is defined unconditionally, so by that reasoning we should be able to use it on all supported platforms indeed. I'll revise this patch, thanks for noticing! Patrick
